Skip to content

Removes the legacy GPU manager, updates the GPU manager to #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 6, 2025
Merged

Removes the legacy GPU manager, updates the GPU manager to #534

merged 3 commits into from
Nov 6, 2025

Conversation

@allenwang28
Copy link
Contributor

@allenwang28 allenwang28 commented Nov 6, 2025

A clean up, and resolves #532

Changes:

  1. Removes legacy code. We had a gpu_manager system controller but it was re-implemented in provisioner. Finally cleans it up
  2. Dynamic GPU detection - GpuManager in provisioner now users torch.cuda.device_count() instead of hardcoding to 8 GPUs.
  3. Adds a function to get GPU information per host to populate GpuManager on remote host meshes.
  4. Updates test cases.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Nov 6, 2025
casteryh
casteryh reviewed Nov 6, 2025
View reviewed changes
Copy link
Contributor

@casteryh casteryh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. why are there only 2 test cases now? Are the old tests no longer relevant because of refactoring?

casteryh
casteryh approved these changes Nov 6, 2025
View reviewed changes
Copy link
Contributor

@casteryh casteryh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@casteryh casteryh merged commit 29c6584 into meta-pytorch:main Nov 6, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@casteryh casteryh casteryh approved these changes

@joecummings joecummings Awaiting requested review from joecummings

@felipemello1 felipemello1 Awaiting requested review from felipemello1

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

GpuManager assumes there are 8 GPUs?

2 participants

@allenwang28 @casteryh